Readit News logoReadit News
woodruffw · a year ago
The TSA's response here is childish and embarrassing, although perhaps unsurprising given the TSA's institutional disinterest in actual security. It's interesting to see that DHS seemingly (initially) handled the report promptly and professionally, but then failed to maintain top-level authority over the fix and disclosure process.
wouldbecouldbe · a year ago
It’s very hard for management, even IT managers, to fully understand what such things mean.

I’ve seen huge issues, like exposed keys, being treated as a small issue. While an outdated js library, or lack of ip6 support being escalated.

I’m sure TSA and their partners wants to downplay potential exposure, I’m also sure it’s hard for a lot of their managers to fully understand what the vulnerability entails (most likely their developers are downplaying their responsibility and pointing fingers at others)

jmholla · a year ago
This is the Transportation SECURITY Agency. If the managers involved here can't understand why this is a huge deal, they're exceptionally unqualified for their jobs.

Edit: Fixed a double negative (previously: This is the Transportation SECURITY Agency. If the managers involved here can't understand why this is a huge deal, they're not exceptionally unqualified for their jobs.)

WarOnPrivacy · a year ago
>> The TSA's response here is childish and embarrassing,

> It’s very hard for management, even IT managers,

I'm confident that the grandparent's comment is correct.

TSA is closer to the issue than HSA; I'd wager big that they sense embarrassment.¹²

TSA management would have immediate access to people capable of framing the issue correctly, including their own parent agency. Their reaction was never going to be held back by technical facts.

    ¹ US Sec/LEO/IC agencies have a long and unbroken history of attacking messengers that bring embarrassment. There is ~no crime they are more dedicated to punishing.

    ² The worlds easiest presupposition: Discussions took/are taking place on how they might leverage the CFAA to deploy revenge against the author.

ensignavenger · a year ago
Part of being a good manager is knowing how to get good folks to give you advice on things you don't understand, and knowing how to follow that advice. Yeah, its hard- but that's a huge part of the whole dang job!

No manager (or human) is perfect, mistakes happen- we need to be humble enough to listen and learn from mistakes.

sweeter · a year ago
TSA is security theater, it is there to give the illusion of security. In reality it seems more like the goal is the entrenchment of surveillance and the appearance of strength.
garyfirestorm · a year ago
> It's interesting to see that DHS seemingly (initially) handled the report promptly...

I think DHS mid level manager yelled at a TSA mid level manager who reported this to the senior TSA officials and then their usual policy kicked in... deny/deflect/ignore

laweijfmvo · a year ago
TSA is DHS, though. At some point, it's the same high-level manager...
macNchz · a year ago
What was surprising to me was that they didn't immediately do pre-dawn raids on the pentesters' homes and hold them without a lawyer under some provision of an anti-terror law.
woodruffw · a year ago
That's not really how this works. TSA is maliciously incompetent, but there is a reporting pipeline and procedure for these things that's formalized and designed to protect exactly this kind of good-faith reporting[1].

(It's very easy to believe the worst possible thing about every corner of our government, since every corner of our government has something bad about it. But it's a fundamental error to think that every bad thing is always present in every interaction.)

[1]: https://www.cisa.gov/report

sixothree · a year ago
There's still _plenty_ of time for that to happen. I wouldn't want to be this person right now. I like my dog alive.
garyfirestorm · a year ago
that is apparently not a popular move anymore since people keep logs and have credentials, strong social media presence and readily available cloud enabled cameras. one email to any news org and whoever authorizes the raid will probably face some music. but knowing TSA, we can expect this any minute now...
noinsight · a year ago
Yeah, I don't know if I would go testing such systems and then reporting the results under my own name (presumably)...

I didn't see any comment about them being contracted to do this at least.

Deleted Comment

Deleted Comment

Dead Comment

dylan604 · a year ago
Since they actually went past the SQL injection and then created a fake record for an employee, I'm shocked that Homeland did not come after and arrest those involved. Homeland would have been top of the list to misinterpret a disclosure and prefer to refer to the disclosure as malicious hacking instead of responsible disclosure. I'm more impressed by this than the incompetence of the actual issue.
aftbit · a year ago
You're not wrong, but I would have a hard time as a jury member convicting them of a CFAA violation or whatever for creating a user named "Test TestOnly" with a bright pink image instead of a photo.

If they had added themselves as known crewmembers and used that to actually bypass airport screening, then yeah, they'd be in jail.

smsm42 · a year ago
That's what jury instructions are for. The judge can instruct the jury to ignore pretty much any facts and consider any subset of what really happened that they want. So they'd just instruct "did they access the system? Were they authorized? If the answer to the first question is yes, and to the second is no, the verdict is guilty, ignore all the rest". The jury won't be from the HN crowd, it would be random people who don't know anything about CFAA or computer systems, it will be the easiest thing in the world to convict. Those guys got so lucky DHS exhibited unusually sensible behavior, they could have ruined their lives.
beaglesss · a year ago
What if they incremented a number in a url on a publicly available website?
mrguyorama · a year ago
>You're not wrong, but I would have a hard time as a jury member

Which is why Jury selection usually removes people who understand the situation.

RHSeeger · a year ago
But would it really matter if they were convicted, after being in jail for who knows how long awaiting trial, losing their job, etc?
newscracker · a year ago
> You're not wrong, but I would have a hard time as a jury member convicting them of a CFAA violation or whatever for creating a user named "Test TestOnly" with a bright pink image instead of a photo. If they had added themselves as known crewmembers and used that to actually bypass airport screening, then yeah, they'd be in jail.

I think it could go any which way. The prosecution could argue that the defendant may have tampered with existing records or deleted some. In this particular case, it’s probable that the system does not have any or adequate audit trails to prove what exactly transpired. Or the claim could be that the defendant exfiltrated sensitive data (or that the defendant is trying to hide it) to share with hostile entities.

IshKebab · a year ago
Yeah so best case you spend tens of thousands on lawyers and probably win.

Doing this under your own name is insane.

cabaalis · a year ago
If anyone from there reads the parent, they should know they have created an atmosphere where the worry of possible prosecution over responsible disclosure has the potential to scare away the best minds in our country from picking at these systems.

That just means the best minds from other, potentially less friendly countries, will do the picking. I doubt they will responsibly disclose.

smsm42 · a year ago
I personally don't comprehend how these people are taking such a huge risks. Once bureaucrat wakes one morning in the wrong mood and your life is ruined at least for the next decade, maybe forever. Why would anyone do it - just for the thrill of it? I don't think they even got paid for it?
newscracker · a year ago
I’m not sure any country’s bureaucracy really appreciates responsible disclosures that make the government’s systems look very poorly designed. There is always the risk of being classified as an enemy agent/criminal depending on who’s reading the report and their own biases.
bryant · a year ago
DHS officially uses bugcrowd, for what it's worth.

https://bugcrowd.com/engagements/dhs-vdp

They've had that relationship for a few years now, so I'm guessing they're somewhat versed. TSA specifically might be less so, but I can't imagine the DHS referring anything to the DOJ for prosecution given that they both have a VDP for the entire department and advise other departments on how to run VDPs (via CISA).

But I might just be overly optimistic.

lyu07282 · a year ago
In some countries where this is the norm, like Germany, the usual route is to report the issue to journalists or to non-profits like the CCC and those then report the issue to the government agency/company. This way you won't get prosecuted for responsible disclosure. Alternatively an even safer route is to write a report and send it to them anonymously with a hard deadline on public/full disclosure, won't get any credit for the discovery this way of course.
beaglesss · a year ago
The statute of limitations is long and HSI often delays their indictment until the investigation is mostly wrapped up.
dylan604 · a year ago
So you're suggesting they're not out of the woods?
mpaco · a year ago
The timeline mentions the disclosure was made through CISA, and on their website there is an official incident report form.

I can imagine an email to some generic email address could have gone down the way you describe, but I guess they look at these reports more professionally.

https://myservices.cisa.gov/irf

neilv · a year ago
Good catch. Of course, different people wear different shades of hat, and I guess the author might have good rationale for going quite as far as they did, I don't know.

Kudos to the author for alerting DHS. Methodology questions aside, it sounds like the author did a service, by alerting of a technical vulnerability that would be plausible for a bad actor to seek out and successfully discover.

But regardless, I hope any new/aspiring security researchers don't read this writeup, and assume that they could do something analogous in an investigation, without possibly getting into trouble they'd sorely regret. Some of the lines are fuzzy and complicated.

BTW, if it turns out that the author made a legality/responsibility mistake in any of the details of how they investigated, then maybe the best outcome would be to coordinate publishing a genuine mea culpa and post mortem on that. It could explain what the mistake was, why it was a mistake, and what in hindsight they would've done differently. Help others know where the righteous path is, amidst all the fuzziness, and don't make contacting the proper authorities look like a mistake.

Enginerrrd · a year ago
I mean... they still might if the wrong people end up getting embarrassed by this. The wheels of bureaucracy are slow.
jerf · a year ago
You know it's bad when it's so bad that as I write this no one has even bothered talking about how bad storing MD5'd passwords is. This even proves they aren't even so much as salting it, which is itself insufficient for MD5.

But that isn't even relevant when you can go traipsing through the SQL query itself just by asking; wouldn't matter how well the passwords were stored.

rachofsunshine · a year ago
This used to be a question on the Triplebyte interview almost verbatim, and a huge percentage of (even quite good) engineers got it wrong. I'd say probably <20% both salted and used a cryptographically-secure hash; MD5 specifically came up all the time. And keep in mind that we filtered substantially before this interview, so the baseline is even worse than that!
rjh29 · a year ago
Damn. Using salts and avoiding MD5 in favour of SHA-1 was well known even around 2005. Rainbow tables were a thing even then.
AntonyGarand · a year ago
The md5 part of the sqli is added by the pentester, likely because they needed a call that would end in a parenthesis within the injection parameter
tomsmeding · a year ago
There is already a call to MD5 in the original query; see the first image in the article, which they apparently obtained by submitting ' as the username: https://images.spr.so/cdn-cgi/imagedelivery/j42No7y-dcokJuNg...
0x0 · a year ago
The screenshot in the article shows MD5() is returned as part of the error message from the web server, so it is probably also a part of the original server-side query.
urbandw311er · a year ago
> We did not want to contact FlyCASS first > as it appeared to be operated only by one person > and we did not want to alarm them

I’m not buying this. Feels more like they knew the site developer would just fix it immediately and they wanted to make a bigger splash with their findings.

biftek · a year ago
This is exactly the kinda bug where you want to make a big splash though. You don't just want the guy to silently fix it, everyone in the database needs to be vetted again.
almog · a year ago
Whatever their motive was, the engineering process that allowed such a common bug to sneak in is broken. If the sole developer immediately fixed it, it would have been hard to escalate the issue so that maybe someone up the chain can fix this systematically. I'm not sure such overhaul would really happen but it's more likely that it won't if not escalated.
conroydave · a year ago
Agreed that they wanted to fully understand the extent of the hack before disclosing
Tepix · a year ago
I came here to say this. Totally uncalled for not to contact the site first that had these holes and instead go to homeland security.
compootr · a year ago
Yes, and what about the possibility that an attacker already accessed this database and added themself as an employee?

Would you rather to be prepared and do a full (well, for a govt agency, full enough) check on all people allowed to access flying death machines, or have a dev silently fix the issue with possible issues later?

norcal · a year ago
ya because the person who developed this is totally trustworthy to fully fix it and assess any other possible vulnerabilities. he definitely isn't gonna just add a front end validation to throw a message on the front end when you submit a single quote...
voiceblue · a year ago
Not surprised that they deny the severity of the issue, but I am quite surprised they didn't inform the FBI and/or try to have you arrested. Baby steps?
woodruffw · a year ago
The author made the right move by doing this through FAA and CISA (via DHS), rather than directly via TSA. It's not inconceivable that a direct report to TSA would have resulted in legal threats and bluster.
dmd · a year ago
Those kind of wheels turn very slowly. I will bet any takers $50 that Ian will be prosecuted.
reaperman · a year ago
I'll take that bet. How long of a time window? 1 year, 2 years?
dmd · a year ago
edit: OK, that's enough takers.
preciousoo · a year ago
This should be news lol, I’m surprised a bored year 17 year old with a fake id hasn’t made a TikTok sneaking on board a plane. Sql injection ffs
justmarc · a year ago
A good old SQL injection negates the entire security theatre worth probably billions a year, hilarious, but probably not all too surprising.
aftbit · a year ago
Does anyone remember Bruce Schneier and his faked boarding passes? The TSA scribble used to be the weak point of the entire system.
mikeocool · a year ago
> We did not want to contact FlyCASS first as it appeared to be operated only by one person...

It seems pretty remarkable that airlines are buying such a security sensitive piece of software from a one person shop. If you make it very far into selling any piece of SaaS software to most companies in corporate America, at the absolute minimum they're going to ask you for your SOC2 audit report.

SOC2 is pretty damn easy to get through with minimal findings as far as audits go, but there are definitely several criteria that would should generate some red flags in your report if the company is operated by a single person. And I would have assumed that if your writing software that integrates with TSA access systems, the requirements would be a whole lot more rigorous than SOC2.

structural · a year ago
The "airlines" that are using something like FlyCASS are themselves smaller operations and typically running on razor thin margins (if not just unprofitable and wishfully thinking that money will suddenly appear and make their business viable). Literally everything on their backend is held together with more duct tape than the average small business.

You could be an "airline" by purchasing a couple of older airliners and converting them to cargo use. Is it valuable for new airlines to get started? Should we force them out of business because they don't already have the systems in place that take years to decades to build out? Should they pay $$$ for boutique systems designed for a large passenger airline when they have 2 aircraft flying 1 route between nowhere and nowhere?

Requirements and audits really aren't the answer here. The fundamental design problem is that the TSA has used authentication "airline XXX says you're an employee" with a very large blanket authorization "you're allowed to bypass all security checks at any airport nationwide" without even the basic step of "does your airline even operate here?"

morpheuskafka · a year ago
I'm curious why a small cargo airline would even need to use the KCM system. If they don't fly passengers, then wouldn't their crew access the aircraft from the cargo ramp (with a SIDA badge) and never need to enter the passenger terminal/sterile area?
mikeocool · a year ago
I mean, yes, in this particular situation it seems like there is many layers of screw ups from several different organizations.

Though given that airlines are responsible for the safety of their crew, passengers, and anyone in the vicinity of their aircraft, requiring them to do some basic vetting of their chosen vendors related to safety and security doesn’t seem unreasonable.

preciousoo · a year ago
This was a wild read, that something like this could be so easy, but the later part describing the TSA response is incredibly alarming