There's a ticket now open to stop this, but it's still in progress.
Fastforward to .NET 5, 6, 7, 8.. it's just doing great x-plat life and innovation
Currently getting this when trying to do an npm run dev:
[plugin externalize-deps] No known conditions for "./vite-plugin" entry in "@spotlightjs/sidecar" package
The plugin "externalize-deps" was triggered by this import
vite.config.ts:7:29:
7 │ import spotlightSidecar from '@spotlightjs/sidecar/vite-plugin';
Should I be telling externalize-deps to leave it alone somehow?Also, I note the PHP SDK has gotten support for Spotlight - are there plans to do the same for the .NET SDK too?
I'm actually looking forward to it, I wanted to try on NuGet Trends but stopped on the first hurdle: https://github.com/dotnet/nuget-trends/pull/247
Seeing as you're "open-source", why chose to fork and detach the project rather than contribute directly to it? With a detached fork, other users can't even compare your changes to the original and pull in fixes. If you truly believed in the spirit of open source, you'd believe in working together and giving back; not just taking advantage of a free lunch.
It feels like all these "open-source" companies are just closed source but with open-source as a marketing gimmick.
The fork exists as a ‘buffer’ to get some changes (features or bug fixes) out without the need to couple with the npm release of rrweb itself. Sentry engineers have several PRs in upstream rrweb merged and the goal is to increase the upstream contributions and close the gap between our fork and upstream. We’re currently porting our changes from v1 to the v2 branch.
I believe Sentry has made financial contributions to rrweb but directly to a maintainer. I'll let others who know details to comment on this. I'm sure more contributions will be done, as this is very much in the interest of Sentry anyway.
Worth noting, Sentry has been making larger contributions to OSS every year, as the company grows:
2021: https://blog.sentry.io/we-just-gave-154-999-dollars-and-89-c... 2022: https://blog.sentry.io/we-just-gave-260-028-dollars-to-open-...
In addition to that, there are contributions to open source done in the form of code that is, open source, such as the symbolication service: https://github.com/getsentry/symbolicator and many others: https://github.com/getsentry/
As of right now we do not capture actual network request headers or bodies.
Avoiding any PII from getting into the system is always top of mind. And we're considering this as an opt-in regardless of scrubbing on the edge ingestion service.
Absolutely no reason other than "C# icky" -- they ended up with a platform that is crazy fast (and fast scales way easier, it handles a dumb amount of traffic without a lot of crazy design)
Startup culture is toxic AF at times, bad engineering decisions for cargo cult stuff.