Readit News logoReadit News
kunwon1 · 2 years ago
It seems to be getting more and more common to leave your git repository completely undocumented. If you're releasing a software project on github, I want to read about it on github.

A basic README that outlines what it does, how it does it, and basic syntax - this is really easy. Table stakes, I might say. I can checkout your repo and I have everything I need to work

zeeg · 2 years ago
Don’t disagree, but technically the docs are in the same repo. Not easily consumed though.

We removed bits from the readme as it kept becoming duplicated and eventually wrong. I think that’s the usual reason folks like to avoid it. DRY and all.

1letterunixname · 2 years ago
It's a terrible habit. Documentation is a nonfunctional requirement. It should describe what is not obvious to someone new and the value of it. Without the conveyance of utility and purpose, all of a project's potential value goes to waste with foot-gunning accuracy.
ren_engineer · 2 years ago
a lot of "open source" companies leave their repos bare so you are forced to go onto their website where they can better track and retarget you
bentlegen · 2 years ago
I assume you're not talking about this company because there is no such script on spotlightjs.com (easily verifiable), and the docs are also actually in the repository:

Example: https://github.com/getsentry/spotlight/blob/main/packages/we...

joshmanders · 2 years ago
Retarget you for what? "Hey you should come back and read the docs on our open source project you were interested in last week"
pb060 · 2 years ago
May I suggest adding some additional context to the home page? While I heard about Sentry I find difficult to understand what Spotlight does. I might not be the intended target audience though.
simonbarker87 · 2 years ago
I agree and find this is the case for many projects like this. I read the homepage and have no idea what the tool does and why I might find it helpful, it wasn’t until I read the inset block on the “Getting Started” page for this one that I had even an inkling what it did.

Most of these types of home page seem to be written assuming I already know what their tool does.

qxxx · 2 years ago
I also have no idea what it does. "Sentry for development", so it works like sentry but the errors are streamed to localhost??
zeeg · 2 years ago
That’s a good way to think about it yeah. It’s not 1:1, and also can be extended beyond Sentry, but that was our MVP.
zeeg · 2 years ago
This seems to be a super shared point of view. I’ll admit we were a bit fire-and-forget on the homepage and definitely agree with all the feedback that we need to explain what it is better.
conor- · 2 years ago
Is this supposed to be intended for people who are already all-in with Sentry? Or can you possibly share some insight as to where this makes sense to use vs instrumenting with an OTEL SDK?
Nthringas · 2 years ago
it looks to me like it covers the same funcionality as browser developer tools

but I am also pretty sure those are going away soon, which will mean the only way to inspect websites will be using tools like this (+ WASM binary formats + google controlled web-runtime[0] means the open web is not open anymore)

[0] https://thewebshowcase.withgoogle.com/bring-code-from-platfo...

sharlos201068 · 2 years ago
Why do you think they'd go away? As far as I'm aware all major browsers continue to add new functionality to their dev tools.
bentlegen · 2 years ago
Your browser's dev tools don't show you what's happening inside your server (and any downstream services) when responding to the browser's HTTP requests. Spotlight does. That's what's special about it.
KTibow · 2 years ago
What? JS isn't getting replaced by WASM. Also some quick Googling says WASM is a joint project by the W3C and multiple browser owners, and debug tools exist for it in Chrome and Firefox already
zeeg · 2 years ago
David from Sentry here. If yall have feedback around Spotlight we’d love to hear it. This is a passion project for a few of us and seemed like a natural fit for our technology, and becomes especially interesting with the service oriented world we all find ourselves in.
patrick91 · 2 years ago
I'd love to see this a replacement for django debug toolbar in future :D
lol768 · 2 years ago
Hey David! Few questions: I'm slightly stuck with the Vite plugin

Currently getting this when trying to do an npm run dev:

    [plugin externalize-deps] No known conditions for "./vite-plugin" entry in "@spotlightjs/sidecar" package
      The plugin "externalize-deps" was triggered by this import
    
        vite.config.ts:7:29:
          7 │ import spotlightSidecar from '@spotlightjs/sidecar/vite-plugin';
Should I be telling externalize-deps to leave it alone somehow?

Also, I note the PHP SDK has gotten support for Spotlight - are there plans to do the same for the .NET SDK too?

brungarc · 2 years ago
Thanks for asking, created a ticket for .NET support here: https://github.com/getsentry/sentry-dotnet/issues/2955

I'm actually looking forward to it, I wanted to try on NuGet Trends but stopped on the first hurdle: https://github.com/dotnet/nuget-trends/pull/247

zeeg · 2 years ago
Let me circle back on the Vite issue. Bundles are the biggest challenge when doing this turns out :)

Would you mind opening a GitHub so we can circle back there?

Regarding .NET - it’s coming to all Sentry SDKs (even mobile!). They were looking at .NET already but I’m not sure off hand what prevented its release. I’d expect our other core languages have full support in the next 60 days.

Deleted Comment

paulirish · 2 years ago
I'm curious. I figure you considered building the UI as a DevTools extension; why 'd you go this in-page-DOM-overlay route instead?
zeeg · 2 years ago
More control and far lower barrier to hack on. This actually opens up a lot of doors for us even if you ignore usability and discoverability. For example, we have a POC that pops the overlay when a server error happens, giving you a rich debug experience where otherwise you might not be able to have one.
amccloud · 2 years ago
Does this new package impact devtools source and initiators in a way where everything is attributed to spotlight?
zeeg · 2 years ago
What’s an example concern? It shouldn’t anymore than Sentry already does
kyawzazaw · 2 years ago
https://spotlightjs.com/ doesn't work

Only http

zeeg · 2 years ago
What error are you seeing? Works over here. Its hosted on Vercel so shouldn’t be too complicated or different than most similar deployments.
arcanemachiner · 2 years ago
Works on my machine.
freedomben · 2 years ago
Apologies if this is a dumb question, but is this related at all to the popular Sentry that captures stack traces and such?

It seems like it isn't, but I can't tell from looking through the website. If it's totally separate, that's a quite unfortunate namespace collision

zeeg · 2 years ago
Its related in that we (Sentry) built it, and that it uses Sentry's open source SDKs to create its payloads, but its separate in that it doesnt require Sentry's monitoring service to work.

Hopefully that helps, and definitely something that is quite tough to clarify but we are still looking to improve upon.

Also added a ticket here to track this in case other folks have thoughts: https://github.com/getsentry/spotlight/issues/243

freedomben · 2 years ago
Ah yes, that helps a ton! So when the doc says "Sentry" it's talking about the Sentry we all know, not a new project called Sentry. Much appreciated

Deleted Comment

simonw · 2 years ago
Feature request: documentation for running this with a Python web app. It looks to me like it should work - the Python Sentry library can presumably publish to the local Spotlight forwarder.

I don't have a npm/npx/etc build mechanism setup, so I'd appreciate instructions for running a separate web server to serve the UI, rather than running the UI integrated directly into my existing Python web application.

zeeg · 2 years ago
Would a bundled JS asset work for the UI? Eg something from a CDN?

Feel free to add a GitHub issue with more details if that’s easier!

simonw · 2 years ago
Yeah, a CDN link would be fine - anything that means I don't have to figure out how to run "npm install" for a project which isn't using that yet.

Or even something like "npx sentry-spotlight-http-server" which starts a server running containing the UI.

waydegg · 2 years ago
>Spotlight is built that you don’t need Sentry to run it

Pretty cool that this is a feature. I was assuming you'd be required to use Sentry to use Spotlight.

zeeg · 2 years ago
Yep- runs fully local! We had to make some small changes to our SDKs to support the sidecar, but a fundamental goal was that this was free software and valuable without the core Sentry service.
naiv · 2 years ago
I am not sure if I fully understand the architecture.

Is the sidecar run on the server or in the client?

zeeg · 2 years ago
Its run on your local device - its just a local devserver that allows Sentry's SDKs to pipe data to it. The overlay (the Spotlight UI) then connects to the sidecar via a Server-Sent Events stream (basically a pubsub HTTP stream which operates unidirectional - think websockets but simpler). This is needed due to the distributed nature of services, but our goal is to push this abstraction into dev servers, e.g. Vite.

Added a ticket to track improving the docs here: https://github.com/getsentry/spotlight/issues/242

naiv · 2 years ago
ok! thank you
ripperdoc · 2 years ago
This doesn't seem to be it, but I always wondered if it would make sense to have an extension to the IDE that uses the aggregated data from Sentry to highlight lines of code that have caused errors or slowdowns.