You need an OpenApi spec!
Readit Newsjtreminio commented on Show HN: Sonauto API – Generative music for developers sonauto.ai/developers... · Posted by u/zaptrem
jtreminio commented on LeetCode but You Can Force People to Code in Light Mode beatcode.dev/... · Posted by u/weebao
> but You Can Force People to Code in Light Mode
As I've aged my preferences have moved away from dark themes to light themes.
I used to have everything in dark mode: terminal, IDE, sublime text, use Dark Reader Chrome extension.
But I can't see shit anymore. I need light!
This is literally what the article advocates.
It pushes things to the extreme where every code you write would be on the main branch and behind a feature flag
Feature flags have nothing to do with trunk or git-flow or feature branches. Simply, taking the entire introduction and asking, why are you not using common tooling?
> On top of that, once you finally get a feature merged and deployed, it can often happen that there’s a bug causing users to have a poor experience. Since your new feature lives directly in the code, deactivating it requires rolling back the code you merged, building it, waiting for the tests to run, and redeploying the application
Why aren’t you using feature flags to gate new behavior/functionality?
jtreminio commented on PHP Docker image just hit 1B pulls on Docker Hub mydevmentor.com/blog/1-bi... · Posted by u/NabilChiheb
PHP is still incredibly big, just not fashionable in silicon valley.
The most surprising thing about this is that PHP developers are using Docker, I would have guessed that most of them are on bare metal or shared hosting. But I guess some of them also like modern deployment methods.
> The most surprising thing about this is that PHP developers are using Docker
Did you think of us as living in a cave forced to connect to a BBS to share the latest on design patterns?
jtreminio commented on Show HN: Dumbo – Hono inspired framework for PHP github.com/notrab/dumbo... · Posted by u/notrab
What do you think of Slim Framework as far as best practices for modern PHP in a micro framework (which is similar to OP's Dumbo)? Are there any other micro frameworks you recommend?
At the risk of being piled on by fans of Slim (see fans of Laravel), I don't use slim frameworks.
For large projects when you get down to it, slim frameworks are simply frameworks where you have to add in components yourself, vs shipping with sane defaults.
Symfony comes with Doctrine, Twig, etc, but you can choose not to use them or even include them.
With slim frameworks if they are built correctly they will have hooks to add these components but you have to choose them and import them and set them up.
I have not worked on a small project in years, and have not bothered looking at slim frameworks in as much time, so my knowledge might be out of date ... but a quick glance through Slim's documentation tells me I'm still fairly close.
jtreminio commented on Show HN: Dumbo – Hono inspired framework for PHP github.com/notrab/dumbo... · Posted by u/notrab
Your whole comment history with regards to PHP reads like someone frustrated that the tool they've chosen to shit on is exactly the opposite of what they think it is but they don't want to admit it.
jtreminio commented on Show HN: Dumbo – Hono inspired framework for PHP github.com/notrab/dumbo... · Posted by u/notrab
Out of curiosity, what do you dislike so much about Laravel?
1) *magic*
2) Its ORM of choice uses ActiveRecord pattern which I find to be hideous. DataMapper is far superior
3) Its weird facade patterns is terrible
I can (and have!) gone in-depth into my misgivings with Laravel, but it is fine for most projects and teams. It has elevated the average codebase quality throughout the PHP community and introduced many engineers to what PHP can do. Its creator and community have been a large net-positive to PHP as a whole.
I still prefer Symfony:
1) explicit 2) DataMapper ORM by default 3) What I am used to
jtreminio commented on Show HN: Dumbo – Hono inspired framework for PHP github.com/notrab/dumbo... · Posted by u/notrab
You're requiring PHP 8.3 but not using some of the most powerful tools in 7+: strict types.
``` /* @var array<string, mixed> Variables stored in the context */ private $variables = []; ```
This should be typed as `array` (heck, I'd argue ArrayObject instead) and all your classes should have `declare(strict_types=1);` at the top.
Your `Dumbo\Helpers` classes are basically static mine traps that you are unable to mock in unit tests. Why does `BasicAuth` expose a single static method but then calls a bunch of other static methods? What ends up happening in any class that uses any of your `Dumbo\Helpers` classes will always run whatever code is defined in these helper classes.
I'm unsure where the bootstrapping process begins. What file does your webserver need to call to handle a new request? I am hoping it is within a root-level directory and not at the root level itself. In other words, `/public/index.php` vs `/index.php`. Your quickstart in README.MD makes it pretty clear that you expect the latter, which is highly unsafe. See any number of poorly configured webservers that stop processing PHP for any reason but now show your site's full contents to anyone passing by.
I would strongly argue against _any_ magic in your framework. Specifically, routes: they should be explicitly defined. I still work with a legacy Symfony 1 framework project and I can't tell you how much I detest magic routing. For a modern example see how Symfony 2+ requires explicit route definition. Heck, how it requires explicit everything because magic should be left to magicians.
Your framework seems like it can only handle `application/json` and `application/x-www-form-urlencoded` requests, but not `multipart/form-data`.
Take these as positive criticisms of your work. It's "fine". I wouldn't use it, I would actively recommend against using it, but I would actively recommend against using anything that's not Symfony (or Laravel if I were drunk). I do not think your project is at the "Show HN" level - it is still far too under-developed.
Any suggestions?