Readit News logoReadit News
Feeble commented on Code review can be better   tigerbeetle.com/blog/2025... · Posted by u/sealeck
jbmsf · 20 days ago
Recently, I've been wondering about the point of code review as a whole.

When I started my career, no one did code review. I'm old.

At some point, my first company grew; we hired new people and started to offshore. Suddenly, you couldn't rely on developers having good judgement... or at least being responsible for fixing their own mess.

Code review was a tool I discovered and made mandatory.

A few years later, everyone converged on GitHub, PRs, and code review. What we were already doing now became the default.

Many, many years layer, I work with a 100% remote team that is mostly experienced and 75% or more of our work is writing code that looks like code we've already written. Most code review is low value. Yes, we do catch issues in review, especially with newer hires, but it's not obviously worth the delay of a review cycle.

Our current policy is to trust the author to opt-in for review. So far, this approach works, but I doubt it will scale.

My point? We have a lot of posts about code review and related tools and not enough about whether to review and how to make reviews useful.

Feeble · 20 days ago
I am very much in the same position right now. My dev team has introduced mandatory code reviews for every change and I can see their output plummeting. It also seems that most code reviews done are mostly syntax and code format related - noone actually seems to run the code or look at the actual logic if it makes sense.

I think its easy to add processes under the good intention of "making the code more robust and clean", but I never heard anyone discuss what is the cost of this process to the team's efficiency.

Feeble commented on Making Your Own Merchant Service Provider   voidfox.com/blog/payment_... · Posted by u/progval
kaishiro · 25 days ago
That's not actually the only issue, unfortunately. Steam did in fact accept Bitcoin for a while, but it was dropped in 2017, with Newell stating:

> “We had problems when we started accepting cryptocurrencies as a payment option. 50% of those transactions were fraudulent, which is a mind-boggling number. These were customers we didn’t want to have.” [1]

[1] https://finance.yahoo.com/news/steam-co-founder-reveals-why-...

Feeble · 25 days ago
That's quite interesting, I wonder how they were fraudulent as bitcoin transactions dont have chargebacks etc. In the article they also mention that the price for the game would fluctuate which seems to indicate they actually priced the games in Bitcoin. Normally price would be Euro, USD etc and price conversion to Bitcoin would be done at check out. I guess these were the early days though =)
Feeble commented on Kanban vs. Scrum: What's the difference?   leiga.com/post/kanban-vs-... · Posted by u/Bryan_YU
pestatije · a year ago
scrum: old buzzword...kanban? whatever, new buzzword in the making
Feeble · a year ago
Kanban predates scrum
Feeble commented on Companies with return-to-office mandates face losing their most valuable workers   rte.ie/brainstorm/2024/05... · Posted by u/ewgfdgdfgdf
Feeble · a year ago
"Remote workers were not only more productive they were more satisfied with remote work than they had been with working in a traditional office"

I think some citation is needed here, there are multiple studies and they have very varied outcome. This one for instance find that productivity drops 18% when working from home: https://www.nber.org/papers/w31515

At best he is cherry picking his studies and ignoring the contrarian studies, at worst he is blindy pushing his own interest and views.

Feeble commented on Amplitude Lays Off 13% of Team (99 people)   amplitude.com/blog/team-u... · Posted by u/joegahona
bsaul · 2 years ago
i hope they're not doing those 10% cut just to look like everyone else. I was about to bet on their product for my analytics and now i'm a bit more hesitant.
Feeble · 2 years ago
Amplitude is a great product. We tested alot of similar products and Amplitude was by far the best. The only negative I have found is their pricing which is free up to quite a generous level to be honest but then it suddenly becomes really expensive.
Feeble commented on Ask HN: Java or JVM based is the best choice for large projects. Prove me wrong    · Posted by u/rlawson
sshine · 3 years ago
Yes, but:

C# is just as good as Java on all accounts.

Rust is just as good as Java except the talent pool is yet growing.

C++ is just as good as Java except the language has no ceiling and the talent pool is shrinking.

Feeble · 3 years ago
C# is just as good from a technical stand point I think, but there is a significant financial cost attached from the licenses. Large server installations with dev, stage, prod & load test envs tend to get expensive with .net.
Feeble commented on Ask HN: Java or JVM based is the best choice for large projects. Prove me wrong    · Posted by u/rlawson
bob1029 · 3 years ago
I won't get into flamewar over Java vs others, but there are some ecosystems that are definitely better suited for large scale development.

The biggest concern for me and my shop is stability over time. We pick tools and vendors that can comfortably support B2B software contracts that are 5+ years long.

Feeble · 3 years ago
Would you mind sharing what ecosystems?
Feeble commented on Ask HN: Java or JVM based is the best choice for large projects. Prove me wrong    · Posted by u/rlawson
Feeble · 3 years ago
I can only agree. Have seen many systems and various tech being used and Java would be my choice for a large project as well.
Feeble commented on The Ethereum merge is done   coindesk.com/tech/2022/09... · Posted by u/mfiguiere
hwillis · 3 years ago
> The switch to PoS is a non-issue from my perspective: a centralized system changed from using method A to method B, I don't understand why I should care.

Because every bitcoin transaction costs $60 in electricity. That is a monumentally stupid amount to pay. It's $125 per kB.

Proof of stake incentivizes capital directly. Proof of work incentivizes capital via the ability to find prime numbers, which limits you to people who are willing to spend $1000s to millions of dollars to do it efficiently. Limiting the validators like that drives up costs massively.

> Bitcoin mining is increasingly being used to prevent methane emissions in stranded gas reserves. Having an economic incentive to not flare or emit methane but instead using it for generating bitcoin allows Bitcoin mining to become net carbon negative.

No, it is not. Projects like that may be branded with bitcoin, but bitcoin miners are buying the same electricity as everyone else. The rising cost of electricity is causing new sources of power to be exploited.

Instead of being used for something useful, that electricity is being turned into waste heat.

Feeble · 3 years ago
The energy is not used to handle the transactions, the energy is used to secure the network.

> Instead of being used for something useful

Bitcoin uses less energy than YouTube. Wether you think having a decentralized, global monetary system that gives everyone an opportunity to own sound money that the government cannot take away is more or less useful than YouTube is of course something everyone is entitled to have an opinion on.

It might be that you are correct, it is too early to tell, but you are no the final judge of what is useful in the world or not, so this quote is just your personal opinion and nothing more.

Feeble commented on I've been abusing HTTP Status Codes in my APIs for years   blog.slimjim.xyz/posts/st... · Posted by u/that_james
treis · 3 years ago
>If the API that the author is building is a REST API then the response for a non-existing resource is 404.

The problem is that this error then overlaps with server path routing issues, DNS problems, and general network issues. Even if it's logically correct it makes dealing with your API annoying.

>Nobody is stoppping anyone to add response body to a 404 to indicate which nested resource is invalid.

But then we've lost standardization which is the whole point of the error codes to begin with.

Feeble · 3 years ago
> But then we've lost standardization which is the whole point of the error codes to begin with.

Returning 200 and then using response body to denote missing resource is no different. So you have to choose, either 404 can be invalid path and missing employee; or 200 can be valid data or missing employee. Personally I would prefer the former as 200/OK then indicates success.

u/Feeble

KarmaCake day256June 1, 2009View Original