Readit News logoReadit News
MiiMe19 · 2 years ago
Very interesting to me that some users just go around and change all mentions of Taiwan and Hong Kong to China, as @alexobviously mentioned in the pull thread. I wonder if the people that do these things do so out of personal patriotism or some other force/factor.
n2d4 · 2 years ago
The particular account in question [1] does enough unrelated stuff to make me believe it's just a patriot who genuinely believes those countries belong to China. Sounds strange until you remember that some people like to start confrontations online for the dumbest reasons.

[1] https://github.com/92hackers

noxs · 2 years ago
this is not much different than many Isarel people genuinely believes Jerusalem is their capital.
satiric · 2 years ago
Reminds me of Tom Scott's video on timezones [1], where he shows how what time zone a user is in can depend on things like ethnicity: apparently, when the West Bank goes on and off Daylight Savings depends on whether you're among Israelis or not (I might have the details wrong here, please correct me if so. I couldn't find much definitive information about this).

Luckily the problem OP linked to seems easier to solve.

[1] https://www.youtube.com/watch?v=-5wpm-gesOY

ThisIsMyAltAcct · 2 years ago
Also reminds me of how Google Maps shows different borders depending on which country you’re viewing from
resolutebat · 2 years ago
This is often due to legal requirements: in both India and China (and many other countries), it's literally illegal to display a map of the country that does not show the "right" borders.
j16sdiz · 2 years ago
The code in question was to decide if you need a proxy to bypass GFW.

Hong Kong does not have the (same) GFW, it is rightly to remove Hong Kong from that list.

That being said, use the locale to determine network connectivity is just.. wrong.

seanmcdirmid · 2 years ago
I was at a fancy hotel in Guangzhou that had internet through HK for some reason. It was nice not being behind the GFW during my stay there. I’m sure there is a better way to tell if you are behind the wall or not.
yieldcrv · 2 years ago
how much does China pay for that level of patriotism?

they pay right? Not just in social credit points I hope

maxglute · 2 years ago
How much does Uncle Sam pay you to mention social credit points? Lots of trolls when you have 1 billion internet users.
PheonixPharts · 2 years ago
Prosperity is the most powerful propaganda of all.

I think few (non-Chinese) people in the US/Europe really understand the dramatic changes that have happened in the last few decades. I have Chinese family members that grew up under literally starvation conditions, only to grow up to find themselves multimillionaires. When Deng Xiaoping went to Shenzen it was a basically a small fishing village, and he said he would make it prosperous and change China's future. It happened. China went from developing nation to second largest economic power in the world in a life time.

For context I am not Chinese and not a fan of the CCP, but the zealous patriotism of the Chinese is not radically different than the zealous patriotism of American's in the immediate postwar period.

When discussing propaganda with Chinese citizens, it's vital to recognize this first. They aren't brainwashed masses, they are largely people who were told outrageous promises by their government, and in fact government policy really made those things happen.

rr808 · 2 years ago
jongjong · 2 years ago
Very different from the west where leaders make mediocre promises of marginal improvements, then fail to deliver on those promises and then they create new significant problems which we didn't have before.
seanmcdirmid · 2 years ago
Chinese were much less patriotic in general 10-20 years ago. They would actually point and laugh at Americans saying they were smarter than that. Times changed a lot since Xi took office. Many are still cynically going through the motions (like when you have to take mandatory ideology classes in high school and college, lots of kids just used to use them for sleep but now they pretend to pay attention).
xialvjun · 2 years ago
You became a millionaire. But I, who had always ranked in the top ten in a small town of more than 100+k people before college, still did not own a house after working for 10+ years.
ThisIsMyAltAcct · 2 years ago
> I have Chinese family members that grew up under literally starvation conditions, only to grow up to find themselves multimillionaires.

The CCP was literally why they were starving in the first place

yieldcrv · 2 years ago
this matches my perception, the patriotism looks the same
sirpunch · 2 years ago
seanmcdirmid · 2 years ago
5 mao used to be able to get you a baked sweet potato on the street in…1999.
renewiltord · 2 years ago
You don't usually pay for that. For instance, as a gooner, I will go make fun of Man Utd fans utterly for free.

Deleted Comment

Dead Comment

bmitc · 2 years ago
The title is an unnecessary editorial of the PR title. Also, this highlights the importance of naming in software. Because, by any account and interpretation, Hong Kong is in China. But that is apparently not what this function is doing, yet it is named "isInChina". It should have been named something else, such as "shouldSetGoProxy", which would resolve any ambiguity.
sgammon · 2 years ago
It's the original PR title. Hong Kong is not "physically" "in" "China" in the same sense as a computer which is physically, or legally, in China, and therefore subject to Great Firewall rules.