https://go-review.googlesource.com/c/go/+/576015 this change to optimise errors.Is in the err == nil case was merged recently. It’s not included in the latest Go release, hence the stats here, but should end up in a release pretty soon I’d imagine.
Readit NewsDeleted Comment
Deleted Comment
Deleted Comment
Deleted Comment
jamespwilliams commented on Go: Sentinel errors and errors.Is() slow your code down by 3000% dolthub.com/blog/2024-05-... · Posted by u/ingve
The happy path is still just nil comparison though:
if err == nil || target == nil {
return err == target
}
Possibly related: https://github.com/golang/go/issues/61502
Looks like they're working on improving the inliner.
That err == nil check was added very recently and isn’t included in the latest Go release, which the author used in this article.
Longer domain names are more secure!
And conversely, short domains like Google’s own g.co are less secure!
Fun weekend project but definitely not production-ready (no tests, no error handling, concurrent requests will cause a race condition, etc.). If readers are looking for something production-ready to use, consider https://github.com/go-redis/redis_rate (which implements GCRA/leaky bucket), or https://github.com/ulule/limiter (which uses a much simpler algorithm, but has good middleware).
Deleted Comment