Readit News logoReadit News
dbjorge commented on Automated accessibility testing at Slack   slack.engineering/automat... · Posted by u/teivah
rasjani · 8 months ago
Been running somewhat similar combo few months and toy'd around with taking the screenshots of the selectors axe-core/playwright reports as I didn't notice such feature in neither playwright or its html reporter. Do you happen to know if slack patched this or is this feature available somehow ?

And if you are willing to answer some other questions regarding axe-core itself, I might have few.

dbjorge · 8 months ago
Screenshots of issues is something we support in many of our paid offerings, but not in axe-core itself. It sounds like the Slack folks implemented their own version of it.

If you have general questions about axe-core, the best place to ask is our axe Community slack instance (https://accessibility.deque.com/axe-community). If you have a specific issue you'd like us to investigate, try https://github.com/dequelabs/axe-core/issues

dbjorge commented on Automated accessibility testing at Slack   slack.engineering/automat... · Posted by u/teivah
dbjorge · 8 months ago
I am one of the maintainers of the axe accessibility testing engine the Slack team is using. It's awesome to see such a detailed writeup of how folks are building on our team's work!

We publish the engine (axe-core) and the "core" playwright integration library Slack is using (@axe-core/playwright) as open source, but if you're interested in what the Slack team has described in this blog, we also have a paid offering called axe Developer Hub (https://www.deque.com/axe/developer-hub) that offers a similar workflow to what the Slack folks describe here: It hooks into end-to-end tests you already have to add in accessibility testing without needing a ton of code changes to your test suite.

It's very enlightening to see which features the Slack folks prioritized for their setup and to see some of the stuff they were able to do by going deep on integration with Playwright specifically. It's not often you are lucky enough to get feedback as strong as "we cared about <feature> enough to invest a bunch of engineering time into it".

If you're interested in building these sort of accessibility tools, my team is hiring! https://www.deque.com/careers/senior-accessibility-tool-deve...

dbjorge commented on A GitHub repository was public-viewable   blog.adafruit.com/2022/03... · Posted by u/zdw
dreamcompiler · 4 years ago
There's nothing particularly wrong with using git for PII, as long as you use it internally on private machines or a private LAN.

But it's a bad idea to put PII on github which is apparently what happened.

dbjorge · 4 years ago
I think that even just on private machines, this would make some types of legal compliance needlessly difficult. If you ever need to delete that data, for example to comply with a corporate retention policy or in response to a request from an individual in a jurisdiction that requires you allow doing so, you would need not just to rewrite history but also to ensure that history is rewritten in every clone that any employee has ever made of that repository; there might not even be a record of which clones exist.
dbjorge commented on Ask HN: What keyboard do you recommend build+use?    · Posted by u/irjustin
bjoli · 4 years ago
Any of the larger Matias keyboards. I love my Matias mini with quiet clicks. It took a couple of days to get used to, but I don't think I will ever look elsewhere. If you want actually tactile switches stear clear of Mx brown.

The quiet clicks have had some reliability issues. The clickies have not.

If you like linear switches, maybe look on any of the contactless keyboards. Wooting, razer huntsman, varmilos electrocapacitive, or steelseries. Those will be much nicer feeling than something like a contact-based linear switch.

dbjorge · 4 years ago
I used the Matias Ergo Pro for exactly 14 months. After the first month I bought a second for home. At 13 months (ie, one month out of warranty), the first one started having reliability issues with the quiet click switches failing. At 14 months the second keyboard started failing in exactly the same way, also one month out of warranty. Their support was unwilling to help outside the warranty period.

Recommend staying away from them.

dbjorge commented on ASCII art for semantic code commenting   asciiflow.com/#/... · Posted by u/anonymous_they
dbjorge · 4 years ago
This is a neat tool, but unfortunately, text art like this generates is extremely unfriendly to folks that use screen readers. If you do use this for comment documentation, consider making sure that there is also a written description above/below it with equivalent descriptive content.
dbjorge commented on Show HN: Web component – Keyboard shortcuts interface for websites   github.com/ssleptsov/ninj... · Posted by u/sergei_ws
dbjorge · 4 years ago
This is a neat concept!

One not-so-obvious accessibility issue with keyboard shortcuts on websites is that if they're too simple (especially single-character), it's easy for them to conflict with assistive technologies like screen readers.

Maybe consider including a pointer to https://www.w3.org/TR/WCAG21/#character-key-shortcuts in the docs (and/or as some sort of warning message if a user tries to configure a custom single character shortcut).

dbjorge commented on Ask HN: What is the most frustrating in web extension development?    · Posted by u/proszkinasenne2
dbjorge · 4 years ago
Living in constant fear that a Google algorithm may someday decide to ban our extension without providing a reason, advance notice, or a meaningful appeals process. It feels like there's some new horror story describing this situation at least once a week here on HN.
dbjorge commented on Yarn 3.0   github.com/yarnpkg/berry/... · Posted by u/Jowsey
dbjorge · 4 years ago
My team is still using yarn v1 because we want both dependabot support (rules out yarn v2+ and pnpm) and support for overriding transitive dependency versions to force security fixes (eg, yarn resolutions). We would love to explore other options but right now yarn v1 seems to be the only game in town that meets those requirements.

Once npm implements their recently-accepted overrides RFC, we're eager to try switching to that.

dbjorge commented on The anti-pattern of responsive design   john.ankarstrom.se/respon... · Posted by u/mrzool
megous · 4 years ago
Yes, but how showing (shoving) everything under a hamburger menu on desktop helps accessibility? Usually if you back from such a full-page menu, you'll completely leave the website, because it's implemented as some <div> overlay with no one bothering to at least push an entry into history, so it looks like navigation but isn't and is in general very confusing.

On mobile people may be using back button less, but on desktop it's always easily visible and accessible in multiple ways, incl. the keyboard, and at least for me it's almost a reflex to use it. Just ctrl+[ away.

dbjorge · 4 years ago
Yes, navigation links that don't behave like normal links are also an accessibility problem[1]. That's a separate issue, though; I don't think it is a reasonable argument against supporting reflow based on perceived window size.

[1] https://www.w3.org/WAI/WCAG21/Techniques/failures/F42

dbjorge commented on The anti-pattern of responsive design   john.ankarstrom.se/respon... · Posted by u/mrzool
lostmyoldone · 4 years ago
While the wording isn't particularly clear, the later remarks contrasting full-width with full-screen makes it clear that full-width in this instance does not refer to the full-width of the screen, but only that the "widest" responsible layout is used.
dbjorge · 4 years ago
I don't think the article is using unclear wording; I think it is clearly arguing the exact opposite of what you're describing. I think the clearest demonstration of this is the concluding section, where the author specifically talks about using "is desktop/laptop" as a preferred alternative to breakpoints that are based on window size.

u/dbjorge

KarmaCake day279March 24, 2019View Original