Readit News logoReadit News
_panva commented on Learn OAuth by building a client with Node.js   annotate.dev/p/hello-worl... · Posted by u/tip_of_the_hat
moltar · 2 years ago
Out of scope

The following features are currently out of scope:

CommonJS

Can’t be the best if CJS support is not offered. I know everyone’s hot for ESM but the fact of the matter is that there is an endless supply of legacy projects that will never migrate to ESM. Deliberately eliminating huge swath of potential users is IMO hostile. Especially because there are tools like tsup that can cross build out of the box.

_panva · 2 years ago
All target runtimes of oauth4webapi natively support ESM. Furthermore, experimental "require(esm)" is coming with Node.js 22 in the coming days, giving library authors such as myself even less of a need to bother with CJS targets, publishing, dual CJS/ESM hassles and more. See https://joyeecheung.github.io/blog/2024/03/18/require-esm-in...
_panva commented on Learn OAuth by building a client with Node.js   annotate.dev/p/hello-worl... · Posted by u/tip_of_the_hat
beanjuiceII · 2 years ago
Certified by the person who wrote the library? I guess I also certify it
_panva · 2 years ago
In self-certification processes like the OIDC certification program, it's common for developers to certify their own software. This is because the process is designed for developers to evaluate their own implementations against the established standards and requirements set by the certification program.

Self-certification doesn't mean that the process lacks validity or rigor. On the contrary, it involves thorough testing and validation against industry standards to ensure that the software meets the necessary criteria for interoperability, security, and functionality.

If you're curious about the specifics of the process, you can find more information on the OIDC certification FAQ pages. These resources provide detailed explanations of the certification process, the criteria for certification, and the testing procedures involved.

_panva commented on “The script will never generate a response” on Cloudflare Workers   zuplo.com/blog/the-script... · Posted by u/yencabulator
kentonv · 3 years ago
Yeah, I think we need to introduce some sort of API for caching parsed objects in a way that avoids all the caveats of using globals...
_panva · 3 years ago
Hi, @panva here. I've previously had Erwin effectively propose the existing code (not the one from the linked article, the one that's in the library today https://github.com/panva/jose/blob/v4.13.0/src/jwks/remote.t...) acknowledging that there is an even more unlikely edge case.

Well, someone was bound to hit that second edge case.

But please help me out on this, the code does not await the _pendingFetch promise and neither does it touch any runtime globals.

So what gives? Please reach out on the cloudflare discord PanvA#6705.

u/_panva

KarmaCake day2March 2, 2023View Original