Readit News logoReadit News
Posted by u/gooob a month ago
What is the most beautiful / highest quality code you've seen (or written)?
literal shower-thought i had tonight as i was thinking about how at work we all don't like dealing with our helm charts because the syntax and structure ends up looking so ugly and it just feels wrong (not to mention the multiple different approaches of handling kubernetes resources in multiple different pipelines.

i try to see beyond any initial repulsion to weird looking code because i know that it may be super functional. but it got me thinking: what makes code beautiful? what makes code "high quality"? (other than that it results in a working, performant, and robust software program obviously).

so i'm curious -- can you show me the best code you've encountered? it can be a small snippet or it can be a "slice of a library" or an architecture etc. have you written anything yourself that you are super proud of?

thisoneisreal · a month ago
The best system I ever worked with looked incredibly simple. Small, clear functions. Lots of "set a few variables, run some if statements." Incredibly unassuming, humble code. But it handled 10s of millions of transactions per day elegantly and correctly. Every weird edge case or subtle concurrency bug or whatever else you could think of had been squeezed out of the system. Everything fit together like LEGO blocks, seamlessly coming together into a comprehensible, functional, performant system. I loved it. After years of accepting mediocre code as the cost of doing business, seeing this thing in a corporate environment inspired me to fall in love with software again and commit to always doing my best to write high quality code.

EDIT: I think what made that code so good is that there was absolutely nothing unnecessary in the whole system. Every variable, every function, every class was absolutely necessary to deliver the required functionality or to ensure some technical constraint was respected. Everything in that system belonged, and nothing didn't.

abc_lisper · a month ago
Was it written by one person?
thisoneisreal · a month ago
The majority of it, yes.
efortis · a month ago
To me, Nginx. I remember seeing this file structure and saying: "ohh, that's how it should be done"

    src/os/win32/ngx_alloc.c
    src/os/unix/ngx_alloc.c
---

A few years later I stumbled upon this refactoring video by Uncle Bob and that was my second aha! moment.

https://web.archive.org/web/20150905163826/https://www.youtu...

---

Many people here recommend Redis as an inspiring example.

jjice · a month ago
It wasn't anything special, but one I took a lot of personal enjoyment in was refactoring a god awful mess of untested, poorly written PHP that was at the core of the company's product. It was to the point that no one one the team wanted to touch it in case they'd break something. The CEO had written it and _hated_ any features being added (but always requested them) because it was so fragile.

I refactored it (on Director of Engineering's request) into discrete classes and functions that read well and were easily tested. Tested all our cases and even found existing bugs that were resolved in the move. This wasn't an incredible amount of code to begin with either. The initial file was probably 400-500 lines of code. This was not the feat of an incredible dev, it was just taking a minute to think and build it out. Most of the team could've also done the same in a day.

And then the CEO didn't like the idea of merging it, despite it being fully unit and integration test, along with a staging and canary testing plan.

I've heard they _still_ don't like to touch that file. The company isn't doing well. I don't think those two are correlated, but I do think the general mindset of the leadership does.

selenehyun · a month ago
It is not open source, but I am still proud of a message delivery system I designed and built alone two years ago. It consists of six independent components and guarantees at least one successful delivery as long as the database remains available. It supports AWS SES, Twilio SMS and MMS, Webhook, Discord messages, and can easily add new providers through an adapter pattern.

Messages are queued through an API, captured by Debezium, produced to Kafka, delivered by workers, logged, and updated through DSNs received via webhook. Failures go to a DLQ where they are retried until the limit is reached.

Each stage runs independently, so any failure only causes minor delay without risking unintended drops. With Prometheus metrics in place, this system has processed more than two hundred thousand messages per day in production for two years without a single reported loss.

lordkrandel · a month ago
Deleted code. Removal of requirements. It's wonderful, letting it go.
az09mugen · a month ago
Code that doesn't exist is code you don't have to maintain. I enjoy that as well.
vismit2000 · a month ago
Pytudes by Peter Norvig: https://github.com/norvig/pytudes
drooby · a month ago
High quality ("beautiful") code is as simple AND legible as possible, while remaining logically correct. All must be present.

It is a balance. And legibility is a fuzzy attribute that depends on the intellectual capacity of the collective observer.

But, beauty is subjective.. some people think maximally terse code is beautiful so... shrug

jamiejquinn · a month ago
One recent HN post I loved recently was on Arthur Whitney's insanely terse C code[0]. I personally find it beautiful, and many others did, but many did not. So it goes.

[0]: https://news.ycombinator.com/item?id=45800777