Readit News logoReadit News
cjhopman commented on “Design choice was made by accounting and legal. Therefore, won’t fix” (2020)   bugs.chromium.org/p/chrom... · Posted by u/sergiomattei
cjhopman · 2 years ago
I don't understand how so many people can discuss this as though it's not some random gmail account that made the comment.
cjhopman commented on “Design choice was made by accounting and legal. Therefore, won’t fix” (2020)   bugs.chromium.org/p/chrom... · Posted by u/sergiomattei
nextaccountic · 2 years ago
What is the legal issue? And what does it have to do with accounting??
cjhopman · 2 years ago
There is none. The comment is from some random gmail account, it doesn't mean anything.
cjhopman commented on Buck2: Our open source build system   engineering.fb.com/2023/0... · Posted by u/mfiguiere
evmar · 2 years ago
How do the "transitive-sets (tsets)" mentioned here compare to Bazel depsets[1]? Is it the same thing with a different name, or different in some important way?

[1] https://bazel.build/rules/lib/depset

cjhopman · 2 years ago
tsets are described in more detail here: https://buck2.build/docs/rule_authors/transitive_sets/. Bazel's depsets were one of the influences on their design. To users, they will seem fairly similar and would be used for solving similar problems, there's some differences in the details of the APIs.

I'm not well-versed on the internal implementation details of bazel's depsets, but one interesting thing about tsets that may further differentiate them is how they are integrated into the core, specifically that we try hard to never flatten them there. The main two places this comes up are: (1) when an action consumes a tset projection, the edges on the DICE graph (our incremental computation edges) only represent the direct tset roots that the action depends on, not the flattened full list of artifacts it represents and (2) when we compute the input digest merkle tree for uploading an actions inputs to RE, that generally doesn't require flattening the tset as we cache the merkle trees for each tset projection node and can efficiently merge them.

u/cjhopman

KarmaCake day8April 6, 2023View Original